Skip to content

Conversation

@apegadoboureghida
Copy link

Changes Made

This pull request addresses an issue in the codebase where the client_id was being verified against the aud claim, which was incorrect. The correct verification should be against the cid claim. This PR updates the code to verify the client_id against the cid claim and ensures the variable names in the code and tests reflect this correction.

Details

  • In the AccessTokenVerifier class, the verify_client_id method has been updated to verify the client_id against the cid claim instead of the aud claim.
  • The corresponding tests have been updated to use the correct variable names.

Reasons for the Change

The previous code was performing an incorrect verification of the client_id against the aud claim, which could lead to validation errors. This update ensures that the client_id is correctly verified against the cid claim, aligning with the intended functionality.

Checklist

  • Code has been updated to verify client_id against the cid claim.
  • Tests have been modified to use the updated variable names.
  • Code and tests have been reviewed for correctness.
  • No new linting or style violations introduced.
  • Existing test suite passes with the changes.

Related Issues

None.

Additional Notes

No additional notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant