Updated code to verify client_id against cid instead of aud. #55
+28
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
This pull request addresses an issue in the codebase where the
client_idwas being verified against theaudclaim, which was incorrect. The correct verification should be against thecidclaim. This PR updates the code to verify theclient_idagainst thecidclaim and ensures the variable names in the code and tests reflect this correction.Details
AccessTokenVerifierclass, theverify_client_idmethod has been updated to verify theclient_idagainst thecidclaim instead of theaudclaim.Reasons for the Change
The previous code was performing an incorrect verification of the
client_idagainst theaudclaim, which could lead to validation errors. This update ensures that theclient_idis correctly verified against thecidclaim, aligning with the intended functionality.Checklist
client_idagainst thecidclaim.Related Issues
None.
Additional Notes
No additional notes.